docs(handbook): stage the four no-registration web baselines (18 → 22)#862
Merged
Conversation
RealUnitCH/web#23 adds a dedicated confirm-page end state with four new visual baselines. Bump the web-baseline count guard and add the matching gallery cards so the next handbook deploy stages the full set.
Contributor
Author
|
Quality gate: 2 review passes (conformance + correctness). Pass 1 finding — the prose comment above the guard still said 18 baselines — was fixed; pass 2 came back clean. Card set, guard value and the four new web baselines were cross-verified against RealUnitCH/web#23 (22 = 22 = 22). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RealUnitCH/web#23 adds a dedicated confirm-page end state (
no-registration) with four new Playwright baselines (18 → 22 PNGs). The handbook deploy stages those baselines behind theEXPECTED_WEB_BASELINE_COUNTguard, which requires the count bump and the matching gallery cards in the same change.Changes
handbook.yaml:EXPECTED_WEB_BASELINE_COUNT18 → 22.docs/handbook/de/index.html(#spec-web): four cards for the new views (desktop de/en, tablet, mobile), mirroring the confirm-invalid card group.Coupling
Merge together with RealUnitCH/web#23 — the guard fails the next handbook deploy if either side lands alone. The PR-level
Handbook Build Checkdoes not stage web baselines, so this PR's CI is unaffected either way.